fix: ArrowSchemaMetadata::GetOption to return empty string instead of raising exception if key is not found. #14157
Conversation
This method was documented to return the empty string if the key was not found, but in actuality it was calling .at() on the unordered_map which raised an exception. This PR fixes this behavior to return the empty string if the key is not found.
|
Hi Rusty, thanks for the PR! This is probably an oversight from making the method const. Since you are already improving this, maybe we could clean up the |
|
Hi @pdet, I hope you had a great weekend! I just added a commit to remove the unnecessary check in Regarding Best, |
Hi Rusty, I hope you had an excellent week as well! I think this is good to go, after all the CI runs pass. |
|
thanks! |
fix: ArrowSchemaMetadata::GetOption to return empty string instead of raising exception if key is not found. (duckdb/duckdb#14157)
fix: ArrowSchemaMetadata::GetOption to return empty string instead of raising exception if key is not found. (duckdb/duckdb#14157) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This method was documented to return the empty string if the key was not found, but in actuality it was calling .at() on the unordered_map which raised an exception. This PR fixes this behavior to return the empty string if the key is not found.