Improve assertion macros #14033
Merged
Improve assertion macros #14033
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
[Arrow] Move `ArrowUtil` to its own file (duckdb/duckdb#13990) Improve assertion macros (duckdb/duckdb#14033)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 3, 2024
[Arrow] Move `ArrowUtil` to its own file (duckdb/duckdb#13990) Improve assertion macros (duckdb/duckdb#14033)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 3, 2024
[Arrow] Move `ArrowUtil` to its own file (duckdb/duckdb#13990) Improve assertion macros (duckdb/duckdb#14033) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming convention of ENV-variables and MACROS across the chain Makefile -> CMakeList.txt -> DuckDB Macro is not always consistent.
For example:
CRASH_ON_ASSERT=1=>-DASSERT_EXCEPTION=0=>-DDUCKDB_CRASH_ON_ASSERT.This PR homogenizes the chains of 2 macros related to assertion handling.
Current situation
Changes in this PR (in$\texttt{\color{green}green}$ )