Proper NULL handling in special json extraction functions #14032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
Fix duckdb/duckdb#13993 - avoid disabling optimizers for SET VARIABLE (duckdb/duckdb#14028) Proper NULL handling in special json extraction functions (duckdb/duckdb#14032) Adds Julia support for scalar UDFs (duckdb/duckdb#14024)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
Fix duckdb/duckdb#13993 - avoid disabling optimizers for SET VARIABLE (duckdb/duckdb#14028) Proper NULL handling in special json extraction functions (duckdb/duckdb#14032) Adds Julia support for scalar UDFs (duckdb/duckdb#14024) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a comment here, I've decided to take a closer look at the
NULLhandling and return types of JSON extraction functions in PostgreSQL and BigQuery, and found that we were inconsistent:json_extract/->should return a JSONnullvalue when doing, e.g.,SELECT '{"duck": null}'->'duck';,json_extract_string/->>/json_valueshould return a SQLNULLvalue.json_valueshould beVARCHAR, notJSON.Both points were not implemented correctly in DuckDB, which this PR fixes.