-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Rework table bindings to be components (catalog
, schema
, table
) instead of flat strings
#14017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8740
Fixes https://github.com/duckdblabs/duckdb-internal/issues/2269
This PR reworks table bindings so that they can have multiple components (
catalog, schema, table
) instead of being a flat string. This is accomplished through theBindingAlias
class. This aligns the way that bindings work with what Postgres does as well, and enables queries like the following to run correctly:In addition, we now fully qualify table names, allowing us to mix and match references to the tables including schemas/catalogs. This fixes queries like the following, which previously failed because
i
would not be considered as equivalent tos1.tbl.i
.