Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Sep 18, 2024

When ignore_errors=true, null_padding = false. we pick the number of columns as the most frequent option.

In case of a tie, we pick the higher number.

Fix: #14001

@pdet pdet changed the title [CSV Reader] Slight change of rules for dialect detection [CSV Sniffer] Slight change of rules for dialect detection Sep 18, 2024
@Mytherin Mytherin merged commit 0ce8631 into duckdb:main Sep 19, 2024
38 of 39 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
[CSV Sniffer] Slight change of rules for dialect detection (duckdb/duckdb#14013)
fix minor typos in comments of aggregate function tests (duckdb/duckdb#14007)
Disable swift linux tests (duckdb/duckdb#14019)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
[CSV Sniffer] Slight change of rules for dialect detection (duckdb/duckdb#14013)
fix minor typos in comments of aggregate function tests (duckdb/duckdb#14007)
Disable swift linux tests (duckdb/duckdb#14019)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@pdet pdet deleted the sniffer_wrench branch November 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_errors parameter is causing data loss during TOO MANY COLUMNS error type
2 participants