fix julia partitions for streaming result #14000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
More descriptive Parquet created_by with version and source hash (duckdb/duckdb#13992) fix julia partitions for streaming result (duckdb/duckdb#14000)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
More descriptive Parquet created_by with version and source hash (duckdb/duckdb#13992) fix julia partitions for streaming result (duckdb/duckdb#14000) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling
nextDataChunkon a streaming result failed to update thechunk_index. This in turn caused the check to prevent double iteration onTables.partitions(q::QueryResult)to fail for streaming data.Now the
chunk_indexis always updated after a successfulnextDataChunkcall. I've added tests that iterating partitions works when it should and throwsNotImplementedExceptionif one attempts to iterate twice.