Skip to content

Format CSV error messages #14097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2024
Merged

Format CSV error messages #14097

merged 2 commits into from
Sep 25, 2024

Conversation

szarnyasg
Copy link
Collaborator

Add some spaces and other seperators.

I spotted in the docs that the formatting of the sniffer's error messages is inconsistent, see https://duckdb.org/docs/data/csv/reading_faulty_csv_files#anatomy-of-a-csv-error

  file= people.csv
  delimiter = , (Auto-Detected)
  quote = " (Auto-Detected)
  escape = " (Auto-Detected)
  new_line = \r\n (Auto-Detected)
  header = true (Auto-Detected)
  skip_rows = 0 (Auto-Detected)
  date_format = (DD-MM-YYYY) (Auto-Detected)
  timestamp_format =  (Auto-Detected)
  null_padding=0
  sample_size=20480
  ignore_errors=false
  all_varchar=0

This PR adds a bunch of whitespace and also other separators for similar error messages.

@szarnyasg szarnyasg requested a review from pdet September 24, 2024 14:29
@Mytherin Mytherin merged commit 89828ab into duckdb:main Sep 25, 2024
44 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@89828ab
d41dbbe 
Format CSV error messages (duckdb/duckdb#14097)
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
@github-actions @krlmlr
chore: Update vendored sources to duckdb/duckdb@89828ab (#469)
55e90ed 
Format CSV error messages (duckdb/duckdb#14097)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pdet pdet pdet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szarnyasg @Mytherin @pdet