Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Sep 24, 2024

This PR allows us to internally create relations that do not require the client context lock when binding.

This is necessary if we try to execute a relation when a client context lock has already been acquired.

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM - one comment:

@Mytherin Mytherin changed the base branch from main to feature September 25, 2024 07:54
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 25, 2024 15:09
@pdet pdet marked this pull request as ready for review October 2, 2024 12:41
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 7, 2024 13:49
@Mytherin Mytherin marked this pull request as ready for review October 7, 2024 14:33
@Mytherin Mytherin merged commit 8644661 into duckdb:feature Oct 8, 2024
43 of 44 checks passed
@pdet pdet deleted the relation_binding branch November 27, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants