Skip to content

Conversation

abramk
Copy link
Contributor

@abramk abramk commented Sep 24, 2024

append_metadata.cmake uses the string(REPEAT) command which was only introduced in cmake 3.15 (https://cmake.org/cmake/help/v3.15/command/string.html)

append_metadata.cmake uses the string(REPEAT) command which was only
introduced in cmake 3.15 (https://cmake.org/cmake/help/v3.15/command/string.html)
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Mytherin Mytherin merged commit e63aba7 into duckdb:main Sep 24, 2024
42 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
Fix parser error by removing alias (duckdb/duckdb#14090)
Bump minimum required cmake version (duckdb/duckdb#14089)
Add duckdb_extension.h to amalgamation release (duckdb/duckdb#14086)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
Fix parser error by removing alias (duckdb/duckdb#14090)
Bump minimum required cmake version (duckdb/duckdb#14089)
Add duckdb_extension.h to amalgamation release (duckdb/duckdb#14086)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants