Skip to content

Fix test #14079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix test #14079

merged 1 commit into from
Sep 24, 2024

Conversation

Tmonster
Copy link
Contributor

taniabogatsch
taniabogatsch approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@taniabogatsch taniabogatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you also trigger the nightly tests on your fork to check if this passes the Block Sizes run?

@Tmonster
Copy link
Contributor Author

sure. https://github.com/Tmonster/duckdb/actions/runs/11008603845

@Mytherin Mytherin merged commit fce7a1f into duckdb:main Sep 24, 2024
26 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@c872465
3a5ff74 
Fix: remove is_probe_in_domain (duckdb/duckdb#14084)
fix maximum_threads test inside containers (duckdb/duckdb#14083)
Fix test (duckdb/duckdb#14079)
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Oct 16, 2024
@github-actions @krlmlr
chore: Update vendored sources to duckdb/duckdb@c872465 (#465)
cce254f 
Fix: remove is_probe_in_domain (duckdb/duckdb#14084)
fix maximum_threads test inside containers (duckdb/duckdb#14083)
Fix test (duckdb/duckdb#14079)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@taniabogatsch taniabogatsch taniabogatsch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tmonster @Mytherin @taniabogatsch