Skip to content

Conversation

khalidmammadov
Copy link
Contributor

  • Adds support using more than one Column instance argument, i.e. as of now it’s only possible to use many str columns but onle one col(“mycol”).
  • It also raises similar PySpark exception when column type is incorrect
  • It also follows similar Apache PySpark API implementation logic.

NOTE: using exclude.append(**str**(col.expr)) does not work as it relies on ToString method which adds extra quotas for simple column names like “name” I.e '"name"' which causes that column to be omitted from drop function. Hence exposing GetName of the Expression. It can also be useful in other places.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 21, 2024 20:21
@khalidmammadov khalidmammadov marked this pull request as ready for review September 21, 2024 20:49
@khalidmammadov
Copy link
Contributor Author

@Tishj can you please review?

@Mytherin Mytherin changed the base branch from main to feature September 24, 2024 14:47
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm 👍

@hannes hannes merged commit 4d05405 into duckdb:feature Oct 2, 2024
19 checks passed
@hannes
Copy link
Member

hannes commented Oct 2, 2024

Thanks!

@hannes hannes changed the title PySpart df.drop() to support expressions PySpark df.drop() to support expressions Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants