Fix #13769: when binding views, always first search in the schema that the view is defined in #13921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma that the view is defined in, followed by searching in the catalog where the view is defined in
Tishj
approved these changes
Sep 13, 2024
2 tasks
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13769
This PR reworks the way that the search path is used during binding. Previously, we would always use the clients' global search path to bind. This PR reworks that so that when binding a view, we expand the search path using the catalog/schema in which the view is located.
This allows us to query views that depend on other elements within the same catalog (e.g. tables or other views), without having to modify the clients' global search path (using e.g. the
USEstatement). This is particularly helpful when attaching databases that contain views.