Fix #13867: use 64-bit random numbers to generate random numbers for random()
#13920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
approved these changes
Sep 13, 2024
2 tasks
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Dec 27, 2024
This is connected to raising RandomEngine to use 64bit state, see duckdb#13920, but initialization need to be done on full range otherwise entropy is limited when many repeated statement are executed. Note that here we only solve the problem for RandomLocalState. A wider rework of the RandomEngine API migth be also handy. Test case provided by @taniabogatsch Fixes duckdb/duckdb-rs#331 Fixes marcboeker/go-duckdb#339 Note that impe
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Dec 28, 2024
This is connected to raising RandomEngine to use 64bit state, see duckdb#13920, but initialization need to be done on full range otherwise entropy is limited when many repeated statement are executed. Note that here we only solve the problem for RandomLocalState. A wider rework of the RandomEngine API migth be also handy. Test case provided by @taniabogatsch Fixes duckdb/duckdb-rs#331 Fixes marcboeker/go-duckdb#339
hannes
added a commit
that referenced
this pull request
Dec 30, 2024
This is connected to raising RandomEngine to use 64bit state, see #13920, but initialization need to be done on full range otherwise entropy is limited when many repeated statement are executed. Note that here we only solve the problem for RandomLocalState. A wider rework of the RandomEngine API would also be also handy, since currently it takes a int64_t that can be either invalid (-1) or valid (>=0), but out of scope here given interactions with sampling PRs make it a larger change. Test case by @taniabogatsch Fixes duckdb/duckdb-rs#331 Fixes marcboeker/go-duckdb#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13867
Previously we were generating 32-bit random numbers for
random(), and using that to return adouble. This PR modifies this behavior so that we instead generate a 64-bit random number. This ensures we don't run into repeated numbers when generating a low amount of random numbers. Note that this changes the random numbers that are generated with specific seeds, hence this requires changing a number of tests.