Fix some warnings found while compiling duckdb-node #13994
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37d64ec to
176dd6d
Compare
This was likely never going to be a problem, but probably it's best fixed
176dd6d to
1706a29
Compare
|
thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Fix some warnings found while compiling duckdb-node (duckdb/duckdb#13994) [Python] Fix issue related to scanning float64 dtype columns that contain a mask (duckdb/duckdb#14170)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 16, 2024
Fix some warnings found while compiling duckdb-node (duckdb/duckdb#13994) [Python] Fix issue related to scanning float64 dtype columns that contain a mask (duckdb/duckdb#14170) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor local code clean up, and a fix for a corner case (unsure if that actually might turn out to be a problem in practice), but probably worth cleaning once I saw them.