Skip to content

More descriptive Parquet created_by with version and source hash #13992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

More descriptive Parquet created_by with version and source hash #13992

merged 1 commit into from
Sep 18, 2024

Conversation

hannes
Copy link
Member

@hannes hannes commented Sep 17, 2024 •
edited
Loading

Now looks like this DuckDB version v1.0.1-dev5504 (build 86723c9912) instead of just DuckDB. At least gives others the chance to special-case their reader if we ever have a bad writer bug.

The spec says

  /** String for application that wrote this file.  This should be in the format
   * <Application> version <App Version> (build <App Build Hash>).
   * e.g. impala version 1.0 (build 6cf94d29b2b7115df4de2c06e2ab4326d721eb55)
   **/

so we're now compliant FWIW

@hannes hannes changed the title More descriptive Parquet writer info with version and source hash More descriptive Parquet created_by with version and source hash Sep 17, 2024
@hannes hannes mentioned this pull request Sep 17, 2024
Closed
2 tasks
@Mytherin Mytherin merged commit e7da966 into duckdb:main Sep 18, 2024
41 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@e7da966
aee2e45 
More descriptive Parquet created_by with version and source hash (duckdb/duckdb#13992)
fix julia partitions for streaming result (duckdb/duckdb#14000)
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
@github-actions @krlmlr
chore: Update vendored sources to duckdb/duckdb@e7da966 (#433)
78d7db9 
More descriptive Parquet created_by with version and source hash (duckdb/duckdb#13992)
fix julia partitions for streaming result (duckdb/duckdb#14000)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@hannes hannes deleted the parquetversion branch October 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannes @Mytherin