Fix partitions on wide tables #13988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6025ea3 to
30d9315
Compare
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
[Fix] Throw exception for UNNEST in lambdas (duckdb/duckdb#13969) Fix partitions on wide tables (duckdb/duckdb#13988)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
[Fix] Throw exception for UNNEST in lambdas (duckdb/duckdb#13969) Fix partitions on wide tables (duckdb/duckdb#13988) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On main branch,
Tables.partitionsfails on table with more than 10 columns. The (somewhat convoluted) reason is that juliantuplefunction when fed aUInt64as second argument, casts it toIntonly if it is<= 10(see JuliaLang/julia#55790). This works in our favor for smalln(number of columns), as the functionColumnConversionDataexpects aInt, not aUInt64, but for largernattempting to collect aTables.partitionsfails.The first commits is a minimal fix + test, whereas the second commit also adds a small refactor to simplify code and make it more robust to this.