Small C Extension API changes #13987
Merged
+47
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypoint returns boolean
This is a minor change to the C Extension API entrypoint: instead of returning void and relying on an extension calling
extension_access->set_error
, we now require extensions to explicitly return true indicating the initialization process was successful. This makes things a bit more pleasant during development because DuckDB will then throw if somehow the initialization process returned early but failed to set an error message:extension_access->set_error
can take nullptrExtensions can now call
extension_access->set_error
with a nullptr for the error message. DuckDB will then just throw a generic error: