fix: remove http prefix from proxy value when present #13973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For anyone tracking this, here's a manual workaround in the meantime: |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
fix: remove http prefix from proxy value when present (duckdb/duckdb#13973)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
fix: remove http prefix from proxy value when present (duckdb/duckdb#13973) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB currently throws the following error for http_proxy values formatted as
http://<proxy_fqdn>:<proxy_port>:InvalidInputException("Failed to parse http_proxy '%s' into a host and port", proxy_value)This PR creates a copy of the
proxy_valueargument withinHTTPUtil::ParseHTTPProxyHostand removes thehttp://prefix if it is present before parsing the hostname and port. It also includes a unit test to cover this new condition.