Fix data race when writing GeoParquet #13962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 26, 2024
Fix data race when writing GeoParquet (duckdb/duckdb#13962) Modify create_art_varchar.benchmark so it passes weekly regressions (duckdb/duckdb#13968)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 26, 2024
Fix data race when writing GeoParquet (duckdb/duckdb#13962) Modify create_art_varchar.benchmark so it passes weekly regressions (duckdb/duckdb#13968) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing GeoParquet, we stored the column-level auxiliary geoparquet statistics/metadata directly in the
GeometryColumnWriter, which is not thread safe, causing issues when multiple row-groups are written concurrently.This PR moves the column-level geoparquet metadata from the
ColumnWriterinto the associatedColumnWriterState, and also introduces a write-lock on the file-level geoparquet metadata struct so that the threads don't race each other when flushing the stats after finishing a row group.Additionally I've changed the
GeometryColumnWriterinto aWKBColumnWriterthat directly subclasses theStringColumnWriterinstead of trying to template the base class as that is significantly messier to do when we also need to wrap the associated state. This makes the code a bit cleaner, and makes sense given that the WKB geometry encoding is the only one we support right now anyway. I've also realized that the implementation for the other encodings is going to end up different enough that there is probably no point in trying to generalize all the geoparquet specific encoding logic into a common base class anyway.Closes: #13914