Fix #13933: disable join filter pushdown when a join is performed over collated columns #13958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed over collated columns
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
Fix duckdb/duckdb#13933: disable join filter pushdown when a join is performed over collated columns (duckdb/duckdb#13958)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 27, 2024
Fix duckdb/duckdb#13933: disable join filter pushdown when a join is performed over collated columns (duckdb/duckdb#13958) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This was referenced Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13933
The issue is that when binding
min/maxwith a collation, the aggregate would be transformed intoarg_min/arg_maxinstead. This expects two input columns rather than a single input column - which then caused problems as the join filter pushdown only passed in a single column. This PR disables join filter pushdown in this scenario (when joining on collated columns).