[Dev] Minor cleanup to BufferManager and BlockHandle API #13838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'shared_ptr<BlockHandle>', but we can just use 'shared_from_this()' instead
… is less confusing
… instead retrieved afterwards from the BufferHandle
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
[Dev] Minor cleanup to BufferManager and BlockHandle API (duckdb/duckdb#13838) [C-API Dev] Fix up `"Test DataChunk populate ListVector in C API"` test (duckdb/duckdb#13839)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
[Dev] Minor cleanup to BufferManager and BlockHandle API (duckdb/duckdb#13838) [C-API Dev] Fix up `"Test DataChunk populate ListVector in C API"` test (duckdb/duckdb#13839) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockHandle::LoadandBlockHandle::LoadFromBufferare no longer static. As a resultBlockHandlenow inherits fromenable_shared_from_thisto enableshared_from_this()[1].BufferManager::Allocatehas lost the out parametershared_ptr<BlockHandle> *block. Instead theBlockHandleis retrieved from the createdBufferHandlewithGetBlockHandle()[1] This works because we always use
make_shared_ptrwhen creating aBlockHandle, but perhaps we should formalize this and make the constructor private, creating a static method that returns ashared_ptrinstead - so a BlockHandle can never be created without ashared_ptrbacking it.