[BufferManager] Fix duckdb_memory() reporting wrong size for temporary_storage_bytes
#13837
+71
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Read, but rather on Delete. If the data is not read before it is deleted the evicted data would not decrease properly
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
[BufferManager] Fix `duckdb_memory()` reporting wrong size for `temporary_storage_bytes` (duckdb/duckdb#13837)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
[BufferManager] Fix `duckdb_memory()` reporting wrong size for `temporary_storage_bytes` (duckdb/duckdb#13837) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
|
Not sure if it's proper place to report. But it seems that I cannot provide a repro as it's very data specific. Any existing reporting on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://github.com/duckdblabs/duckdb-internal/issues/2805
evicted_data_per_taggets increased inWriteTemporaryBuffer, but gets decreased inReadTemporaryBuffer.This meant that
evicted_data_per_tagwould never decrease if the temporary buffer was not read before it was destroyed.This PR moves this logic to
DeleteTemporaryFilewhich will happen both when the buffer is read (as it gets subsequently destroyed) and also when it is destroyed before reading.