When vacuuming, immediately checkpoint the vacuumed row groups instead of scheduling a checkpoint task #13825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13825 from Mytherin/interleavevacuumcheckpoint
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13825 from Mytherin/interleavevacuumcheckpoint Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if we are vacuuming many row groups, the system was first vacuuming everything into in-memory row groups, followed by checkpointing them later on. By directly executing the checkpoint we can checkpoint the row groups while they are still fresh in-memory, and we avoid having to keep them in-memory for an extended period of time.
This partially alleviates the need for the max_vacuum_tasks introduced in #13811 - although having a limit is likely still a good idea.