[Dev] Remove unnecessary parameter from BufferHandle constructor #13823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also have a couple follow up changes to this, a bigger one is changing the prototype of from: virtual BufferHandle Allocate(MemoryTag tag, idx_t block_size, bool can_destroy = true,
shared_ptr<BlockHandle> *block = nullptr) = 0;to: virtual BufferHandle Allocate(MemoryTag tag, idx_t block_size, bool can_destroy = true) = 0;The |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13823 from Tishj/buffer_handle_cleanup Merge pull request duckdb/duckdb#13821 from Tishj/python_3_13_fix
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13823 from Tishj/buffer_handle_cleanup Merge pull request duckdb/duckdb#13821 from Tishj/python_3_13_fix Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I noticed while working on something related to the buffer manager.
BufferHandle takes a BlockHandle and a FileBuffer pointer, but it's a raw pointer so unless the lifetime is guaranteed by an outside scope, providing anything other than the
handle->buffer.get()can cause a heap use after free issue.Tracing back the lineage, this originates from an age before we had
BlockHandle: Mytherin@7251a55#diff-bf94710a9036c38ee30044ac99f5752dc2bddfda44cd3f82992d992501f3d956