Add requested_schema argument to PyCapsule interface #13802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66e66cd to
6c4972d
Compare
6c4972d to
e9dcac8
Compare
e9dcac8 to
62ff2db
Compare
62ff2db to
38489c4
Compare
kylebarron
reviewed
Sep 6, 2024
| @@ -412,7 +412,7 @@ class DuckDBPyRelation: | |||
| def list(self, column: str, groups: str = ..., window_spec: str = ..., projected_columns: str = ...) -> DuckDBPyRelation: ... | |||
|
|
|||
| def arrow(self, batch_size: int = ...) -> pyarrow.lib.Table: ... | |||
| def __arrow_c_stream__(self) -> object: ... | |||
| def __arrow_c_stream__(self, requested_schema: Any) -> object: ... | |||
There was a problem hiding this comment.
I'm not sure if this will produce any issues, but the spec document suggests typing this as object | None = None https://arrow.apache.org/docs/format/CDataInterface/PyCapsuleInterface.html#protocol-typehints
There was a problem hiding this comment.
Actually, this will mess with type checkers as long as you don't have =None
Pylance doesn't allow this:
from typing import Protocol, Any
class ArrowStreamExportable(Protocol):
def __arrow_c_stream__(self, requested_schema: object | None = None) -> object: ...
def accepts_arrow(data: ArrowStreamExportable): ...
class ArrowObject:
def __arrow_c_stream__(self, requested_schema: Any) -> object: ...
obj = ArrowObject()
accepts_arrow(obj)with error:
Argument of type "ArrowObject" cannot be assigned to parameter "data" of type "ArrowStreamExportable" in function "accepts_arrow"
"ArrowObject" is incompatible with protocol "ArrowStreamExportable"
"__arrow_c_stream__" is an incompatible type
Type "(requested_schema: Any) -> object" is not assignable to type "(requested_schema: object | None = None) -> object"
Parameter "requested_schema" is missing default argument
There was a problem hiding this comment.
Nice catch - thanks!
38489c4 to
57a53d1
Compare
kylebarron
reviewed
Sep 6, 2024
| @@ -412,7 +412,7 @@ class DuckDBPyRelation: | |||
| def list(self, column: str, groups: str = ..., window_spec: str = ..., projected_columns: str = ...) -> DuckDBPyRelation: ... | |||
|
|
|||
| def arrow(self, batch_size: int = ...) -> pyarrow.lib.Table: ... | |||
| def __arrow_c_stream__(self) -> object: ... | |||
| def __arrow_c_stream__(self, requested_schema: Optional[object]) -> object: ... | |||
There was a problem hiding this comment.
You still need to provide = None, see #13802 (comment)
57a53d1 to
8c4e21e
Compare
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13745 from pdet/decimal_cast Merge pull request duckdb/duckdb#13802 from WillAyd/add-requested-schema
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13745 from pdet/decimal_cast Merge pull request duckdb/duckdb#13802 from WillAyd/add-requested-schema Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue described in https://github.com/duckdb/duckdb/pull/13418/files#r1746662887