Copy From Database - create a balanced UNION ALL tree instead of a depth-first union all tree to avoid stack overflows #13889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pth-first union all tree to avoid stack overflows
This was referenced Sep 12, 2024
Mytherin
added a commit
that referenced
this pull request
Sep 16, 2024
Follow-up from #13889 - also fix this in `EXPORT` and unify code
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Copy From Database - create a balanced UNION ALL tree instead of a depth-first union all tree to avoid stack overflows (duckdb/duckdb#13889)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Copy From Database - create a balanced UNION ALL tree instead of a depth-first union all tree to avoid stack overflows (duckdb/duckdb#13889) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COPY FROM DATABASEcreates a number ofINSERTstatements, unified throughUNION ALLoperators to execute this as a single plan. This PR reworks how these union all statements are created to create a balanced tree instead of a depth-first tree, leading to a much less deep tree. This avoids stack overflows later on when copying databases with many tables.