Improve error on enums #13885
Merged
Improve error on enums #13885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
943cc5d to
ef3c4bd
Compare
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Improve error on enums (duckdb/duckdb#13885) [Python] Add `python_scan_all_frames` to opt-in to scanning all frames (< 1.1 behavior) (duckdb/duckdb#13896)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Improve error on enums (duckdb/duckdb#13885) [Python] Add `python_scan_all_frames` to opt-in to scanning all frames (< 1.1 behavior) (duckdb/duckdb#13896) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the error messages in cases of missing enum case to be more verbose, given this has basically no additional cost but grants some more information on what the system is doing at the moment the exception is thrown.
Before (using a bug that will be independently fixed in the meantime as example):
After: