Explicit windows-2019 instead of windows-latest #13883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using windows-latest meant defaulting to a recent Windows SDK, that caused issues such as duckdb#13848 or duckdb#13864 Thanks everyone for reporting this, and @szarnyasg and @Mytherin for helping figuring this out
carlopi
added a commit
to carlopi/extension-ci-tools
that referenced
this pull request
Sep 12, 2024
carlopi
added a commit
to duckdb/extension-ci-tools
that referenced
this pull request
Sep 12, 2024
Port duckdb/duckdb#13883 to extension-ci-tools, now building on windows-2019
carlopi
added a commit
to duckdb/extension-ci-tools
that referenced
this pull request
Sep 12, 2024
carlopi
added a commit
to carlopi/duckdb-odbc
that referenced
this pull request
Sep 12, 2024
I have NOT tried this, sort of relying on CI for now. Connected to this duckdb's PR duckdb/duckdb#13883, and related failures. I think also ODBC driver would need to be built on an older Windows machine for it to be compatible with say Windows Server 2019.
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Preserve operator in `BindWithCTE` (duckdb/duckdb#13873) CI/Windows: Drop redundant package (duckdb/duckdb#13874) Explicit windows-2019 instead of windows-latest (duckdb/duckdb#13883)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Preserve operator in `BindWithCTE` (duckdb/duckdb#13873) CI/Windows: Drop redundant package (duckdb/duckdb#13874) Explicit windows-2019 instead of windows-latest (duckdb/duckdb#13883) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
staticlibs
added a commit
to staticlibs/duckdb-odbc
that referenced
this pull request
Mar 5, 2025
This change is a continuation of duckdb/duckdb#13883 and duckdb#34. While the duckdb#24 appeared to be unrelated, it still makes sense to use older Windows version on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using windows-latest meant defaulting to a recent Windows SDK, that caused issues such as #13848 or #13864
Issue is, at his core, that we were depending on a Microsoft Visual C++ Redistributable package that is not installed by default on Windows 2019.
Thanks everyone for reporting this, and @szarnyasg and @Mytherin for helping figuring this out.
This PR provide a way forward for build artifact that will be built, but also allow a blueprint (and the means) on how to rebuild
v1.1.0release Windows artifacts, that will likely happen tomorrow. This will offer a solution after downloading new artifacts, after we can confirm they work.Other duckdb repositories might have the same problem, and would need to be reviewed.