13810 unnest cross join error #13878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/2979
The original plan with no optimization looks like this
The UNNEST has an index, and is a blocking operator (I think?). The filter above it is extracted so that it can be used as a potential join filter. The problem here is that the filter has bindings from the unnest, so when we attempt to use it to join the two tables, the join order optimizer will throw an error because the filter bindings (which are only available above the unnest) are not available below the unnest.
The solution I have for this is to optimize everything below the unnest separately. In the future I may want to implement a pushdown/pullup unnest optimizer to find the best place to put an unnest.