Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Sep 11, 2024

This PR extends the keyword search from the parser to take an optional parameter with matching categories.

Is currently used to normalize CSV column names names that match either reserved or type func keywords.

Fix: #13794

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one comment

@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 12, 2024 09:44
@pdet pdet marked this pull request as ready for review September 12, 2024 10:31
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 12, 2024 12:53
@pdet pdet marked this pull request as ready for review September 12, 2024 13:07
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 13, 2024 11:39
@Mytherin Mytherin marked this pull request as ready for review September 13, 2024 13:43
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 16, 2024 09:46
@pdet pdet marked this pull request as ready for review September 16, 2024 09:47
@Mytherin Mytherin merged commit b2f6801 into duckdb:main Sep 16, 2024
39 of 40 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@aborruso
Copy link

Thank you very much

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Sep 27, 2024
Parser Keyword Category Search (duckdb/duckdb#13875)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@pdet pdet deleted the reserved_keyword_search branch November 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalize_names does not work properly with /dev/stdin
3 participants