Throw at double/float cast to decimal if it does not fit #13745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Sep 4, 2024
| Could not convert string "9.99" to DECIMAL(1,0) | ||
|
|
||
| statement error | ||
| Could not cast value 9.990000 to DECIMAL(1,0) |
There was a problem hiding this comment.
This is probably not the SQL that you intend to execute here
|
Thanks for the PR! LGTM - could you just fix the test case? |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13745 from pdet/decimal_cast Merge pull request duckdb/duckdb#13802 from WillAyd/add-requested-schema
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Merge pull request duckdb/duckdb#13745 from pdet/decimal_cast Merge pull request duckdb/duckdb#13802 from WillAyd/add-requested-schema Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://github.com/duckdblabs/duckdb-internal/issues/2049