fix REGEX not supported anymore for valid queries (only statement error) #2889 #13633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would consider adding a test of this behaviour, to avoid future regression and as demo / documentation, something like: or equivalent |
66d45b9 to
1ef86cd
Compare
1ef86cd to
ed3329b
Compare
Thank you @carlopi , that is a good point. I've added one test |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Only bind to SQL value functions if there is no alias with this name present we can bind to instead (duckdb/duckdb#13925) [Python][Jupyter] Don't use `ExplainFormat::HTML` for `explain('analyze')` (duckdb/duckdb#13928) [CI] Invert operations on OSX.yml, deploying nightly artifacts before test (duckdb/duckdb#13927) fix REGEX not supported anymore for valid queries (only statement error) duckdb/duckdb#2889 (duckdb/duckdb#13633) [Python] Improve `install_extension` to support `repository`/`repository_url` and `version` (duckdb/duckdb#13876) Remove buffer_manager_allocate.patch and bump spatial (duckdb/duckdb#13895)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Only bind to SQL value functions if there is no alias with this name present we can bind to instead (duckdb/duckdb#13925) [Python][Jupyter] Don't use `ExplainFormat::HTML` for `explain('analyze')` (duckdb/duckdb#13928) [CI] Invert operations on OSX.yml, deploying nightly artifacts before test (duckdb/duckdb#13927) fix REGEX not supported anymore for valid queries (only statement error) duckdb/duckdb#2889 (duckdb/duckdb#13633) [Python] Improve `install_extension` to support `repository`/`repository_url` and `version` (duckdb/duckdb#13876) Remove buffer_manager_allocate.patch and bump spatial (duckdb/duckdb#13895) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the https://github.com/duckdblabs/duckdb-internal/issues/2889
The function matching expected and actual result messages,
FullMatch(), didn't work well with a reference to aMaterializedQueryResultobject (&result.ToString()) casted to a string.What changed: pass the (expected) result to the match checking function as a string instead of passing an object by reference.