Skip to content

[Feature] Allow passing the catalog (database name) to appender #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2024
Merged

[Feature] Allow passing the catalog (database name) to appender #13692

merged 8 commits into from
Oct 7, 2024

Conversation

taniabogatsch
Copy link
Contributor

No description provided.

Tishj
Tishj reviewed Sep 6, 2024
View reviewed changes
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 6, 2024 14:47
@taniabogatsch taniabogatsch requested a review from Tishj September 9, 2024 08:46
@taniabogatsch taniabogatsch marked this pull request as ready for review September 9, 2024 08:46
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 16, 2024 15:38
@taniabogatsch taniabogatsch marked this pull request as ready for review September 16, 2024 15:39
@duckdb-draftbot duckdb-draftbot marked this pull request as draft September 23, 2024 15:38
@taniabogatsch taniabogatsch marked this pull request as ready for review September 23, 2024 15:39
Tishj
Tishj approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@Giorgi
Copy link
Contributor

Giorgi commented Oct 1, 2024

Will the changes be exposed to the C API as well?

@taniabogatsch
Copy link
Contributor Author

@Giorgi, yes, that's the plan. 👍

@Giorgi
Copy link
Contributor

Giorgi commented Oct 2, 2024

@Giorgi, yes, that's the plan. 👍

Great, I just had one of the users of the .NET library ask about it yesterday: Appender & attached database

@Mytherin Mytherin merged commit 47f9930 into duckdb:feature Oct 7, 2024
40 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Oct 7, 2024

Thanks!

@taniabogatsch taniabogatsch deleted the pass-catalog-to-appender branch October 7, 2024 10:58
@ylorph
Copy link

ylorph commented Oct 8, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Tishj Tishj Tishj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taniabogatsch @Giorgi @Mytherin @ylorph @Tishj