Move the block size constant out of the compression functions #12235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #12283. Also might need changes, as the nightly run was borked on |
|
I'll close this PR in favour of smaller PRs. Working on it has shown that once I swap some of the constants going to storage, I probably need to do the entire switch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit 'boring' as it mostly changes function definitions. 👀
Relevant changes.
CompressionInfoto pass arbitrary relevant data to the different compression functions, such as the physical type and the storage manager's block size.Next up (not included to keep the PR compact).
int32_t, as we need to downcast its type in some functions.