[Fix][ADBC] Don't filter system catalogs/schemas in ConnectionGetObjects #11618
+644
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 12, 2024
Merge pull request duckdb/duckdb#11618 from joellubi/adbc-getobjects-no-filter Merge pull request duckdb/duckdb#11623 from Tishj/modular_extension_entries_generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #11446
Removes filtering of system catalogs (
system,temp) and schemas (information_schema,pg_catalog). There is no actual requirement to omit these objects and by leaving them in, the client may decide themselves whether to include them.Additionally, adding these catalogs/schemas surfaced a bug in the previous implementation where other objects were getting duplicated because of a bad join on the schemata. This has been corrected in the underlying SQL queries.