Improve hive type auto-casting so that it looks at all files instead of only the first file #11676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of only the first file
This was referenced Apr 16, 2024
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 16, 2024
Merge pull request duckdb/duckdb#11676 from Mytherin/hivetypesautocast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9763
Fixes #11636
Previously the hive auto-type detection would only look at the first file, which provided inconsistent behavior. We now look at all files and merge the types during auto-detection, falling back to
VARCHARif the types cannot be merged.