Skip to content

Conversation

chrisiou
Copy link
Contributor

@chrisiou chrisiou commented Apr 15, 2024

This PR includes two changes:

  1. Tests involving the unzip functionality are avoided in Python's test runner (this is not supported yet).
  2. The unzip.test requires:
  • a 64-bit system (this is because the data/storage/index_0-9-1.db is being written with a 64-bit version of duckdb)
  • a maximum block_size of 262144
  • a maximum vector_size of 2048

@chrisiou chrisiou requested a review from Tishj April 15, 2024 14:42
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 15, 2024 15:18
Copy link
Contributor

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM :)

@chrisiou chrisiou marked this pull request as ready for review April 15, 2024 16:56
@Mytherin Mytherin merged commit 40ae548 into duckdb:main Apr 16, 2024
@Mytherin
Copy link
Collaborator

Thanks!

@chrisiou chrisiou deleted the support-gzipped-files branch April 16, 2024 08:25
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Apr 16, 2024
Merge pull request duckdb/duckdb#11616 from pdet/multiple_nullstr
Merge pull request duckdb/duckdb#11662 from carlopi/patches
Merge pull request duckdb/duckdb#11658 from chrisiou/support-gzipped-files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants