[Vacuum] Fix serialization and Copy of the VacuumStatement #11656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
commented
Apr 15, 2024
| select_list.push_back(std::move(result.expression)); | ||
| } | ||
| info.columns = std::move(non_generated_column_names); | ||
| // Creating a table without any physical columns is not supported |
There was a problem hiding this comment.
I removed the else here that was setting has_table to false when select_list was empty.
Because this can't happen.
This was preparing for a scenario where a table exists that has no physical columns, only consisting of generated columns, which can't happen because that's not supported.
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 16, 2024
Merge pull request duckdb/duckdb#11656 from Tishj/statement_copy_verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an internal issue we found related to the VacuumStatement.
VacuumStatement::Copy was not implemented correctly, and also VacuumStatement::Serialize/Deserialize
These have now been fixed.