Limit batch insert threads based on available memory, similar to Parquet write #11655
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 15, 2024
Merge pull request duckdb/duckdb#11655 from Mytherin/limitbatchinsertthreads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10756 introduced a limit to the number of threads for Parquet write based on available memory and how wide the table is - 4MB per column per thread. This also turns out to be beneficial for batched writes, especially for wide tables. Below is a benchmark of copying a table with 3000 columns to a DuckDB table using various thread counts and memory limits. As shown, with a low memory limit, limiting the threads is beneficial since less data will be written to the temporary directory.