Skip to content

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Apr 14, 2024

We have our own signing mechanism, and they conflict making the Apple signature invalid

Until a few days ago, for nightly or releases extensions, we built the binary, codesigned, then applied our signature on top (making the Apple signature not valid anymore).
With the extension metadata rework, we applied our own signature as part of cmake, and this breaks the preconditions of Apple codesigning.
Even if that would be solved, we still modify the binary afterwards.

And another connected problem: codesigning was performed only for extensions built directly by duckdb/duckdb workflows, and not for out-out-tree ones (then possibly updated to extensions.duckdb.org).

All consider, I think the proper solution is just removing the codesigning step on extensions. To be reviewed whether it makes sense and can be introduced everywhere.

We have our own signing mechanism, and they conflict making the Apple
signature invalid
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Apr 15, 2024
Merge pull request duckdb/duckdb#11645 from wangxiaoying/ec0
Merge pull request duckdb/duckdb#11652 from carlopi/no_macos_codesign_extensions
@carlopi carlopi deleted the no_macos_codesign_extensions branch May 7, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants