Skip to content

Filter out single relation predicates before join ordering #11645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

Filter out single relation predicates before join ordering #11645

merged 2 commits into from
Apr 15, 2024
+5 −5

Conversation

wangxiaoying
Copy link
Contributor

Fixes #11638

@wangxiaoying wangxiaoying mentioned this pull request Apr 14, 2024
Closed
2 tasks
@Mytherin Mytherin requested a review from Tmonster April 14, 2024 08:24
@duckdb-draftbot duckdb-draftbot marked this pull request as draft April 15, 2024 05:35
@wangxiaoying wangxiaoying marked this pull request as ready for review April 15, 2024 05:35
Tmonster
Tmonster approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing the bug, investigating it, and providing a fix.

@Mytherin Mytherin merged commit 4476a91 into duckdb:main Apr 15, 2024
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Apr 15, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@4476a91
4edd4f8 
Merge pull request duckdb/duckdb#11645 from wangxiaoying/ec0
Merge pull request duckdb/duckdb#11652 from carlopi/no_macos_codesign_extensions
@wangxiaoying
Copy link
Contributor Author

Happy to help : ) Thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Tmonster Tmonster Tmonster approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero cardinality estimation lead to disastrous join ordering (on parquet tpch q21)
3 participants
@wangxiaoying @Mytherin @Tmonster