Skip to content

Fix more issues found by the fuzzer, extend SQL reduction further #11642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 13, 2024
Merged

Fix more issues found by the fuzzer, extend SQL reduction further #11642

merged 16 commits into from
Apr 13, 2024

Conversation

Mytherin
Copy link
Collaborator

This PR fixes a number of issues found by the fuzzer:

  • ABS for hugeint did not correctly handle overflows
  • repeat did not correctly handle blobs
  • Signed integer overflow could happen in array_slice
  • sum_no_overflow could be called manually as opposed to being generated by the optimizer, which could naturally result in a signed integer overflow happening
  • Fix an issue when combining QUALIFY with LATERAL joins

In addition we further extend the reduce_sql_statement method so queries can be reduced even more effectively.

Mytherin added 16 commits April 12, 2024 12:48
@Mytherin
Fuzzer - avoid signed overflow in ORDER BY
e056dd0
@Mytherin
Add simplification to STAR expressions
612310e
@Mytherin
Improved simplification for subqueries and set operations
9940483
@Mytherin
Further extend query simplification
75fcbbf
@Mytherin
Correctly handle NULL argument in pragma_metadata_info
da2d435
@Mytherin
Fix for array_slice with numeric limits
a31c433
@Mytherin
Check overflow for hugeint in Abs function correctly
a6d3e8f
@Mytherin
Further expand statement simplifier
60a1cdc
@Mytherin
Correctly handle NULL value in quantile_cont
4a60a0e
@Mytherin
Fuzzer fixes for repeat blobs, clean up "repeat" code
a15af9f
@Mytherin
Fix interaction of LATERAL joins and QUALIFY clause
4cf13fe
@Mytherin
sum_no_overflow is now for internal usage only - it can no longer be …
0e7d577 
…manually called
@Mytherin
Add test back with mode skip
aeaf479
@Mytherin
Edit in json
6c2933b
@Mytherin
Fix issue in debug code in cardinality estimator + add sum no overflo…
a47a844 
…w tests
@Mytherin
Implement serialize functions for sum_no_overflow
bac0103
@Mytherin Mytherin merged commit 38dd6c5 into duckdb:main Apr 13, 2024
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Apr 13, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@38dd6c5
168477d 
Merge pull request duckdb/duckdb#11642 from Mytherin/fuzzerissues2
@Mytherin Mytherin deleted the fuzzerissues2 branch June 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mytherin