[CI] Remove GITHUB_PAT variable from R-CMD-check #11593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tmonster
approved these changes
Apr 10, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 10, 2024
Merge pull request duckdb/duckdb#11585 from Mytherin/dbgenreadonly Merge pull request duckdb/duckdb#11593 from carlopi/remove_github_pat Merge pull request duckdb/duckdb#11577 from szarnyasg/update-issue-template2 Merge pull request duckdb/duckdb#11592 from Mytherin/drafttoken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GITHUB_TOKEN is now available with restricted read-only capability, so I was making a review of the places where this was used, and this is the last remaining case.
I am not sure if GITHUB_PAT as a role anymore, or this can be safely removed.
Opening the PR to figure this out, also given the recent changes to duckdb/duckdb-r this looks more likely to be outdated.