Fix #11393 - improve error message when trying to use a lateral join column in a table function that does not support it #11436
+42
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… join column in a table function that does not support it
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 31, 2024
Merge pull request duckdb/duckdb#11436 from Mytherin/improvelateralerror
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11393
DuckDB has two types of table functions - table in-out functions and "standard" table functions. Standard table functions are more flexible/versatile and support e.g. parallel execution, but must operate on constant input parameters. Currently, when trying to use a lateral join column with such a function, the column is interpreted as a varchar instead which provides a confusing error message. In this PR, we try to bind such columns using the lateral join binder, and if we find a matching candidate we throw a more descriptive error message.
For example, after this PR: