[ODBC] Fix: Support loading UTF-8 encoded data with Power BI #11423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment with initial report of this issue: #10907 (comment) |
1 task
added 3 commits
March 29, 2024 13:50
… to SQLGetInfo for reading UTF-8 encoded files in Power Query SDK and Power BI
bc6ec9c to
59fca1d
Compare
|
Rebased branch onto |
maiadegraaf
approved these changes
Apr 9, 2024
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 9, 2024
Merge pull request duckdb/duckdb#11580 from Mytherin/unneststructcleanup Merge pull request duckdb/duckdb#11576 from szarnyasg/reprox-labels Merge pull request duckdb/duckdb#11575 from Mytherin/permissions Merge pull request duckdb/duckdb#11423 from guenp/guenp/fix-sqlgetinfo-1750-unknown-attribute Merge pull request duckdb/duckdb#11382 from guenp/guenp/ignore-pq-driver-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes motherduckdb/duckdb-power-query-connector#16
When reading UTF-8 encoded data from DuckDB via Power Query SDK or Power BI, the ODBC driver's diagnostics logs return errors:
This is likely due to Power Query sending
SQLGetInforequests withTypeInfovalues that are not supported by the ODBC driver, in particular,SQL_DTC_TRANSACTION_COST(1750) andSQL_RETURN_ESCAPE_CLAUSE(180) . This PR adds support for theseInfoTypes toSQLGetInfoto enable reading UTF-8 encoded files in Power Query SDK and Power BI. I also added a line to add theinfo_typeto the diagnostics logs.Some relevant info from MS docs:
See a similar implementation in the PostgreSQL ODBC driver here on line 1047.
Before fix:
After fix:
See here for repro steps.