Give preference to FSSPEC defined FS #11400
Merged
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
reviewed
Mar 28, 2024
|
|
||
| def test_fsspec_priority(self, require): | ||
| pytest.importorskip("fsspec") | ||
| pytest.importorskip("gscfs") |
There was a problem hiding this comment.
I think this will not be tested because the python extension CI job will not have gscfs installed, do we want to add this to make sure it gets tested on CI?
There was a problem hiding this comment.
Instead we could create a dummy filesystem that corresponds to the "gcs" protocol, just to test that it gets picked over the system one
There was a problem hiding this comment.
tools/pythonpkg/tests/fast/test_filesystem.py does this I believe, in test_multiple_protocol_filesystems
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 30, 2024
Merge pull request duckdb/duckdb#11400 from pdet/preference_fsspec
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #10698