Fix #11444: avoid using recursion in string -> list parsing #11498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 5, 2024
Merge pull request duckdb/duckdb#11498 from Mytherin/issue11444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11444
The offending query creates a very long list of deeply nested brackets (
[{"a":[{"a":[{"a":[{"a":[{"a":[{"a":[{"a":....). The string to list parsing algorithm used recursion when dealing with brackets, which caused this to trigger a stack overflow. This PR reworks the algorithm to use a vector instead.