Issue #11292: Nested Boolean Compares #11496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have somewhat strange comparison semantics for nested types where the top level produced NULL when comparing NULLs but we used DISTINCT semantics lower down. This was surprising, didn't match Postgres, and wasn't stable if you pulled the contents up a level e.g., via UNNEST. Several tests were relying on these semantics. Most of them could be fixed by changing them to using DISTINCT comparisons, but a small number were producing incorrect results and have been corrected. fixes: duckdb#11292 fixes: duckdblabs/duckdb-internal#1657
Fix a missed slow test. fixes: duckdb#11292 fixes: duckdblabs/duckdb-internal#1657
lnkuiper
suggested changes
Apr 4, 2024
src/include/duckdb/common/vector_operations/vector_operations.hpp
Outdated
Show resolved
Hide resolved
PR feedback: Use optional_ptr for new argument. fixes: duckdb#11292 fixes: duckdblabs/duckdb-internal#1657
PR Feedback: Use optional_ptr for legacy arguments. fixes: duckdb#11292 fixes: duckdblabs/duckdb-internal#1657
PR Feedback: Undo optional_ptr for __restrict keyword arguments. fixes: duckdb#11292 fixes: duckdblabs/duckdb-internal#1657
lnkuiper
approved these changes
Apr 5, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 5, 2024
Merge pull request duckdb/duckdb#11496 from hawkfish/nested-nulls
|
Wonderful! Thank you so much, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have somewhat strange comparison semantics for nested types
where the top level produced NULL when comparing NULLs but we used
DISTINCT semantics lower down. This was surprising, didn't match Postgres,
and wasn't stable if you pulled the contents up a level e.g., via UNNEST.
Several tests were relying on these semantics. Most of them could
be fixed by changing them to using DISTINCT comparisons, but a small number
were producing incorrect results and have been corrected.
fixes: #11292
fixes: https://github.com/duckdblabs/duckdb-internal/issues/1657