Check for IUTF8 flag defined before setting it #11488
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Are these CI failures a result of the change? I’ve looked at several other PRs, most of which are also failing the Windows/Linux extension check (including #11247 which was merged). |
|
Thanks for the PR! LGTM. CI failures are unrelated indeed - we are still dealing with some CI failures as a fall-out from the xz repo being removed. |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 5, 2024
Merge pull request duckdb/duckdb#11497 from Mytherin/issue11445 Merge pull request duckdb/duckdb#11488 from patmaddox/conditional-iutf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11487
Problem: Compilation fails on FreeBSD 13 because
IUTF8is not definedSolution: Check for
IUTF8defined before setting flag