Fix extension builds #11486
Merged
Fix extension builds #11486
+23
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18eb412 to
4545ca7
Compare
|
Previous sqlite patch compiled but failed the test due to me misunderstanding the API of |
4545ca7 to
8c770d7
Compare
|
I think I have got it right at last. Proper test is whether any extension job will complete. They do already pass the compile step, that is better than tonight, ideally they should also pass all tests. |
Mytherin
reviewed
Apr 3, 2024
8c770d7 to
4ebc48a
Compare
4ebc48a to
b2dbdbd
Compare
b2dbdbd to
62853d4
Compare
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Apr 5, 2024
Merge pull request duckdb/duckdb#11486 from carlopi/fix_extension_builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixup connected to more wider usage of
optional_idx, now restoring extensions CI support.Also removing 2 unneded patches that I had left hanging.